-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[msg] Reorder header bits to match spec. #7861
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bzbarsky-apple
approved these changes
Jun 24, 2021
/rebase |
01c5d64
to
ba28aa2
Compare
Size increase report for "gn_qpg6100-example-build" from ed677f0
Full report output
|
Size increase report for "nrfconnect-example-build" from ed677f0
Full report output
|
Size increase report for "esp32-example-build" from ed677f0
Full report output
|
woody-apple
approved these changes
Jun 24, 2021
yufengwangca
approved these changes
Jun 24, 2021
mspang
approved these changes
Jun 24, 2021
saurabhst
approved these changes
Jun 28, 2021
jmartinez-silabs
approved these changes
Jun 28, 2021
nikita-s-wrk
pushed a commit
to nikita-s-wrk/connectedhomeip
that referenced
this pull request
Sep 23, 2021
* [msg] Reorder header bits to match spec. * Restyled by clang-format Co-authored-by: Restyled.io <commits@restyled.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The SDK message header flags do not match the specification.
Change overview
In order to write tools that dissect the Matter message format, this PR attempts to align the SDK implementation with the latest specification of the message flags and security flags fields. This PR is a minimal change set. Follow on tasks include:
Fixes #7772. Fixes #7773. Fixes #7774.
Testing
The existing CI does a good job of validating encode / decode paths for the header flags.