Typo/Comments Cleanup for IM writeClient and writeHandler

[yunhanw-google]

Problem

• Fix Review comments for WriteClient/Handler PR #7795

Change overview

Cleanup Typo and imrpove comments for IM write client and write Handler

Testing

The existing test cover this.

[todo]

we temprarily create a SecureSessionHandle from node id, this will be fixed in PR 3602

connectedhomeip/src/app/WriteClient.cpp

Lines 258 to 261 in e27e903

	// TODO: we temprarily create a SecureSessionHandle from node id, this will be fixed in PR 3602
	// TODO: Hard code keyID to 0 to unblock IM end-to-end test. Complete solution is tracked in issue:4451
	if (apSecureSession == nullptr)
	{

---

This comment was generated by todo based on a TODO comment in e27e903 in #7975. cc @yunhanw-google.

[todo]

we temporarily create a SecureSessionHandle from node id, this will be fixed in PR 3602

connectedhomeip/src/app/WriteClient.cpp

Lines 258 to 261 in 13dc554

	// TODO: we temporarily create a SecureSessionHandle from node id, this will be fixed in PR 3602
	// TODO: Hard code keyID to 0 to unblock IM end-to-end test. Complete solution is tracked in issue:4451
	if (apSecureSession == nullptr)
	{

---

This comment was generated by todo based on a TODO comment in 13dc554 in #7975. cc @yunhanw-google.

[todo]

we temporarily create a SecureSessionHandle from node id, this will be fixed in PR 3602

connectedhomeip/src/app/WriteClient.cpp

Lines 258 to 261 in 13dc554

	// TODO: we temporarily create a SecureSessionHandle from node id, this will be fixed in PR 3602
	// TODO: Hard code keyID to 0 to unblock IM end-to-end test. Complete solution is tracked in issue:4451
	if (apSecureSession == nullptr)
	{

---

This comment was generated by todo based on a TODO comment in 13dc554 in #7975. cc @yunhanw-google.

[github-actions]

Size increase report for "esp32-example-build" from 1039cef

File	Section	File	VM
chip-all-clusters-app.elf	.flash.rodata	8	8
chip-all-clusters-app.elf	.flash.text	-12	-12
chip-all-clusters-app.elf	.dram0.bss	0	-32

Full report output

BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-all-clusters-app.elf and ./pull_artifact/chip-all-clusters-app.elf:

sections,vmsize,filesize
.debug_loc,0,126
.debug_ranges,0,16
.flash.rodata,8,8
[Unmapped],0,-8
.flash.text,-12,-12
.debug_aranges,0,-16
.dram0.bss,-32,0
.debug_abbrev,0,-37
.debug_frame,0,-48
.symtab,0,-64
.shstrtab,0,-86
.xt.prop._ZN4chip8BitFlagsINS_9Messaging22ReliableMessageContext5FlagsEtE3SetES3_b,0,-100
.strtab,0,-150
.debug_line,0,-189
.debug_str,0,-195
.debug_info,0,-4969

Comparing ./master_artifact/chip-pigweed-app.elf and ./pull_artifact/chip-pigweed-app.elf:

sections,vmsize,filesize

[github-actions]

Size increase report for "nrfconnect-example-build" from 1039cef

File	Section	File	VM
chip-lock.elf	bss	0	-32
chip-lock.elf	text	-96	-96
chip-shell.elf	device_handles	4	4
chip-shell.elf	text	-68	-68

Full report output

BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-lock.elf and ./pull_artifact/chip-lock.elf:

sections,vmsize,filesize
.debug_frame,0,8
.shstrtab,0,-2
.debug_abbrev,0,-30
.symtab,0,-32
bss,-32,0
.strtab,0,-66
text,-96,-96
.debug_loc,0,-101
.debug_line,0,-193
.debug_str,0,-195
.debug_ranges,0,-224
.debug_info,0,-3857

Comparing ./master_artifact/chip-shell.elf and ./pull_artifact/chip-shell.elf:

sections,vmsize,filesize
device_handles,4,4
.shstrtab,0,-1
.debug_aranges,0,-8
.debug_frame,0,-24
.debug_abbrev,0,-30
.symtab,0,-32
.strtab,0,-67
text,-68,-68
.debug_str,0,-118
.debug_line,0,-203
.debug_ranges,0,-216
.debug_loc,0,-234
.debug_info,0,-1199

[bzbarsky-apple]

Approved with the two comment fixes.

[github-actions]

Size increase report for "gn_qpg6100-example-build" from 22c1082

File	Section	File	VM
chip-qpg6100-lighting-example.out	.text	-32	-32

Full report output

BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-qpg6100-lighting-example.out and ./pull_artifact/chip-qpg6100-lighting-example.out:

sections,vmsize,filesize
.debug_loc,0,83
.debug_frame,0,32
[Unmapped],0,32
.debug_line,0,14
.debug_aranges,0,8
.strtab,0,1
.shstrtab,0,-1
.debug_ranges,0,-8
.text,-32,-32
.debug_info,0,-35
.debug_str,0,-74

Comparing ./master_artifact/chip-qpg6100-lighting-example.out.map and ./pull_artifact/chip-qpg6100-lighting-example.out.map:

BLOAT EXECUTION FAILED WITH CODE 1:
bloaty: unknown file type for file './pull_artifact/chip-qpg6100-lighting-example.out.map'

Resolved