Fix admin id used in the peer-to-local session in messaging context. #8049
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this, trying to use NewExchangeToLocal to simulate an unsolicited incoming message fails to do the right thing because we end up not matching up the MRP ack to the message's exchange correctly, since the admin ids mismatch.
pullapprove
bot
requested review from
andy31415,
chrisdecenzo,
Damian-Nordic,
hawk248,
jepenven-silabs,
msandstedt and
woody-apple
kghost
approved these changes
Jul 1, 2021
saurabhst
approved these changes
Jul 1, 2021
msandstedt
approved these changes
Jul 1, 2021
woody-apple
approved these changes
Jul 2, 2021
nikita-s-wrk
pushed a commit
to nikita-s-wrk/connectedhomeip
that referenced
this pull request
Sep 23, 2021
…roject-chip#8049) Without this, trying to use NewExchangeToLocal to simulate an unsolicited incoming message fails to do the right thing because we end up not matching up the MRP ack to the message's exchange correctly, since the admin ids mismatch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this, trying to use NewExchangeToLocal to simulate an
unsolicited incoming message fails to do the right thing because we
end up not matching up the MRP ack to the message's exchange
correctly, since the admin ids mismatch.
Problem
Tests that I was trying to write failed.
Change overview
Use what I think is the right admin id for the secure session here.
Testing
Will be tested by those tests I am trying to write.