Use gen/ids into im_cluster_command_handler.cpp #8069
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ands.h in src/app/zap-templates/templates/app/im-cluster-command-handler.zapt
pullapprove
bot
requested review from
andy31415,
bzbarsky-apple,
chrisdecenzo,
Damian-Nordic,
hawk248,
jepenven-silabs and
msandstedt
bzbarsky-apple
approved these changes
Jul 1, 2021
msandstedt
approved these changes
Jul 1, 2021
saurabhst
approved these changes
Jul 1, 2021
woody-apple
approved these changes
Jul 2, 2021
nikita-s-wrk
pushed a commit
to nikita-s-wrk/connectedhomeip
that referenced
this pull request
Sep 23, 2021
* Use src/app/common/gen/ids/Clusters.h and src/app/common/gen/ids/Commands.h in src/app/zap-templates/templates/app/im-cluster-command-handler.zapt * Update generated gen/IMClusterCommandHandler.cpp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
This PR uses
gen/idsfiles withconstexprinside namespaces instead of the code generated forgen/command-id.handgen/cluster-id.h.Testing
I have locally runned the test suites to validate the commands/clusters works.