Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[nrfconnect] Add support for nRF52840 Dongle to lighting-app #8080

Merged
merged 3 commits into from
Jul 3, 2021

Conversation

Damian-Nordic
Copy link
Contributor

Problem

nRF Connect Lighting Example can be built for nRF development kits, but not for nRF52840 Dongle although it's feasible.

Change overview

Adapt the example to work on the dongle (enable USB CDC device class for shell and logging).
Add a shell command dfu which reboots the dongle into the bootloader (to upgrade the firmware without physically pressing the reset button).

Testing

Successfully commissioned and controlled the lighting-app on nRF52840 Dongle

Allow to build nRF Connect Lighting Example for the
nRF52840 Dongle.
@Damian-Nordic Damian-Nordic changed the title Dongle shell [nrfconnect] Add support for nRF52840 Dongle to lighting-app Jul 2, 2021
@restyled-io restyled-io bot mentioned this pull request Jul 2, 2021
@github-actions
Copy link

github-actions bot commented Jul 2, 2021

Size increase report for "nrfconnect-example-build" from 2478e02

File Section File VM
chip-shell.elf rodata 8 8
chip-shell.elf text 8 8
chip-shell.elf device_handles -8 -8
chip-lock.elf device_handles 8 8
chip-lock.elf rodata 8 4
chip-lock.elf text 8 8
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-shell.elf and ./pull_artifact/chip-shell.elf:

sections,vmsize,filesize
.debug_info,0,270
.debug_loc,0,63
.symtab,0,32
.debug_frame,0,20
.debug_str,0,13
.debug_line,0,9
.debug_aranges,0,8
rodata,8,8
text,8,8
.debug_abbrev,0,-7
device_handles,-8,-8
.debug_ranges,0,-32

Comparing ./master_artifact/chip-lock.elf and ./pull_artifact/chip-lock.elf:

sections,vmsize,filesize
.debug_info,0,270
.debug_loc,0,67
.symtab,0,32
.debug_frame,0,20
.debug_line,0,13
.debug_str,0,13
.debug_aranges,0,8
device_handles,8,8
rodata,4,8
text,8,8
.debug_abbrev,0,-7
.debug_ranges,0,-32


@woody-apple
Copy link
Contributor

@woody-apple woody-apple merged commit c3edd9a into project-chip:master Jul 3, 2021
nikita-s-wrk pushed a commit to nikita-s-wrk/connectedhomeip that referenced this pull request Sep 23, 2021
…-chip#8080)

* [nrfconnect] Add support for nRF52840 Dongle to lighting-app

Allow to build nRF Connect Lighting Example for the
nRF52840 Dongle.

* Apply code review comments

* Restyled by prettier-markdown

Co-authored-by: Restyled.io <commits@restyled.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants