-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[linux] Enable setup code options for linux example apps #8547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
bzbarsky-apple,
chrisdecenzo,
Damian-Nordic,
hawk248,
jepenven-silabs and
msandstedt
July 21, 2021 16:28
yufengwangca
changed the title
[TE4] Enable setup code options for linux example apps
[linux] Enable setup code options for linux example apps
Jul 21, 2021
mspang
approved these changes
Jul 23, 2021
Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
msandstedt
approved these changes
Jul 23, 2021
Size increase report for "nrfconnect-example-build" from 762a204
Full report output
|
Size increase report for "esp32-example-build" from 762a204
Full report output
|
bzbarsky-apple
approved these changes
Jul 28, 2021
Not active on Matter anymore. |
saurabhst
approved these changes
Jul 28, 2021
nikita-s-wrk
pushed a commit
to nikita-s-wrk/connectedhomeip
that referenced
this pull request
Sep 23, 2021
…p#8547) * [TE4] Enable setup code options in linux example apps * Update src/app/server/OnboardingCodesUtil.cpp Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> * Update src/app/server/OnboardingCodesUtil.cpp Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> * Rename QRCode to qrCode * Apply suggestions from code review Co-authored-by: Justin Wood <woody@apple.com> Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
What is being fixed? Examples:
currently, example app always generate setup code with default Device Configuration, CSG would like to add options to allow configure QRcode/setup code with linux example apps for CSG tests validation.
Fixes Enhance Lighting example app to use user provided QRcode or setup code #8404
Change overview
Enable setup code options for linux example apps
Testing
How was this tested? (at least one bullet point required)