Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop assuming CHIP_ERROR is an integer in Darwin code. #8585

Conversation

bzbarsky-apple
Copy link
Contributor

Some of the fixes have to do with the fact that %@ is not a format
ChipLogging supports, not strictly with the CHIP_ERROR changes.

Problem

Various Darwin-specific code assumes that a CHIP_ERROR is an int.

Change overview

Stop making those assumptions.

Testing

Compiled code, locally ran Darwin tests.

Some of the fixes have to do with the fact that %@ is not a format
ChipLogging supports, not strictly with the CHIP_ERROR changes.
@bzbarsky-apple bzbarsky-apple force-pushed the darwin-stop-assuming-chip-error-int branch from af7c2a0 to f2d5cab Compare July 23, 2021 00:35
@github-actions
Copy link

Size increase report for "esp32-example-build" from f382df3

File Section File VM
chip-temperature-measurement-app.elf .flash.text 47 60
chip-lock-app.elf .flash.text 64 64
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-persistent-storage.elf and ./pull_artifact/chip-persistent-storage.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-temperature-measurement-app.elf and ./pull_artifact/chip-temperature-measurement-app.elf:

sections,vmsize,filesize
[Unmapped],0,4049
.flash.text,60,47

Comparing ./master_artifact/chip-lock-app.elf and ./pull_artifact/chip-lock-app.elf:

sections,vmsize,filesize
.flash.text,64,64
[Unmapped],0,-64

Comparing ./master_artifact/chip-all-clusters-app.elf and ./pull_artifact/chip-all-clusters-app.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-shell.elf and ./pull_artifact/chip-shell.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-ipv6only-app.elf and ./pull_artifact/chip-ipv6only-app.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-pigweed-app.elf and ./pull_artifact/chip-pigweed-app.elf:

sections,vmsize,filesize


@yufengwangca yufengwangca merged commit 712b67f into project-chip:master Jul 23, 2021
@bzbarsky-apple bzbarsky-apple deleted the darwin-stop-assuming-chip-error-int branch July 27, 2021 17:03
nikita-s-wrk pushed a commit to nikita-s-wrk/connectedhomeip that referenced this pull request Sep 23, 2021
…8585)

Some of the fixes have to do with the fact that %@ is not a format
ChipLogging supports, not strictly with the CHIP_ERROR changes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants