Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement command ResetWatermarks for Software Diagnostics Cluster #8685

Merged
merged 1 commit into from
Jul 29, 2021
Merged

Implement command ResetWatermarks for Software Diagnostics Cluster #8685

merged 1 commit into from
Jul 29, 2021

Conversation

yufengwangca
Copy link
Contributor

Problem

What is being fixed? Examples:

TODO: Reset the value of the StackFreeMinimum field for every thread to the value of the corresponding thread’s StackFreeCurrent field when accessory helper APIs for list and struct are ready.

Change overview

On receipt of command ResetWatermarks, the Node SHALL set the value of the CurrentHeapHighWaterMark attribute to
the value of the CurrentHeapUsed attribute.

Testing

How was this tested? (at least one bullet point required)
Reset Software diagnostic counts
./chip-tool softwarediagnostics reset-watermarks 0
Confirm the value of the CurrentHeapHighWaterMark attribute is set to the value of the CurrentHeapUsed attribute.

@github-actions
Copy link

Size increase report for "esp32-example-build" from b77bfb0

File Section File VM
chip-ipv6only-app.elf .flash.text -172 -172
chip-all-clusters-app.elf .flash.rodata 176 176
chip-all-clusters-app.elf .flash.text 104 104
chip-temperature-measurement-app.elf .flash.text 56 56
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-shell.elf and ./pull_artifact/chip-shell.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-lock-app.elf and ./pull_artifact/chip-lock-app.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-ipv6only-app.elf and ./pull_artifact/chip-ipv6only-app.elf:

sections,vmsize,filesize
[Unmapped],0,172
.flash.text,-172,-172

Comparing ./master_artifact/chip-persistent-storage.elf and ./pull_artifact/chip-persistent-storage.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-all-clusters-app.elf and ./pull_artifact/chip-all-clusters-app.elf:

sections,vmsize,filesize
.debug_info,0,412
.debug_line,0,344
.flash.rodata,176,176
.strtab,0,166
.flash.text,104,104
.debug_abbrev,0,78
.debug_loc,0,46
.symtab,0,32
.debug_frame,0,12
.shstrtab,0,2
[Unmapped],0,-280

Comparing ./master_artifact/chip-pigweed-app.elf and ./pull_artifact/chip-pigweed-app.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-temperature-measurement-app.elf and ./pull_artifact/chip-temperature-measurement-app.elf:

sections,vmsize,filesize
.flash.text,56,56
[Unmapped],0,-56


@yufengwangca yufengwangca merged commit 3fbc10e into project-chip:master Jul 29, 2021
@yufengwangca yufengwangca deleted the pr/cluster/resetwatermarks branch July 29, 2021 23:54
rcasallas-silabs pushed a commit to rcasallas-silabs/connectedhomeip that referenced this pull request Aug 2, 2021
nikita-s-wrk pushed a commit to nikita-s-wrk/connectedhomeip that referenced this pull request Sep 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement the ResetWatermarks in the platform layer.
5 participants