-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Echo]: Fix OnResponseTimeout is not fired when SendMessage fails #9096
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
chrisdecenzo,
jelderton,
LuDuda,
mspang and
saurabhst
August 17, 2021 22:55
yunhanw-google
approved these changes
Aug 17, 2021
Size increase report for "esp32-example-build" from 6ef58ba
Full report output
|
Size increase report for "nrfconnect-example-build" from 6ef58ba
Full report output
|
andy31415
approved these changes
Aug 18, 2021
saurabhst
approved these changes
Aug 18, 2021
LuDuda
approved these changes
Aug 18, 2021
nikita-s-wrk
pushed a commit
to nikita-s-wrk/connectedhomeip
that referenced
this pull request
Sep 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
What is being fixed? Examples:
We found OnResponseTimeout was not triggered if SendMessage failed during test, this is regression from previous releases.
This regression is caused by recent ExchangeContext API change, just setting send flag kExpectResponse is not enough,
client also needs to explicitly set response timeout value (> 0) to enable response timeout handler.
Fixes OnResponseTimeout cannot be fired when SendMessage fails fo send. #9093
Change overview
Set response timeout value during echo SendMessage
Testing
How was this tested? (at least one bullet point required)