-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove duplicate attribute path in IM Read #9389
Remove duplicate attribute path in IM Read #9389
Conversation
f540729
to
6a43ddd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I might be missing something, but I don't see tests sufficiently updated to verify this.
6a43ddd
to
76912f0
Compare
76912f0
to
562c0cf
Compare
Yep, just forgot to add the checker, thanks for pointing it out, with two duplicated path, I add one additional check to check if only one attribute path has processed. |
562c0cf
to
68a9234
Compare
Size increase report for "gn_qpg-example-build" from 5815350
Full report output
|
68a9234
to
d238bc6
Compare
d238bc6
to
81e48b6
Compare
Summary of Changes: --Remove duplicate attribute paths if there are multiple overlapped path in read attribute path for IM Read --Add unit test for multiple overlapped path Restyled by clang-format Restyled by clang-format
81e48b6
to
f044876
Compare
Size increase report for "esp32-example-build" from 5815350
Full report output
|
Size increase report for "nrfconnect-example-build" from 5815350
Full report output
|
Summary of Changes: --Remove duplicate attribute paths if there are multiple overlapped path in read attribute path for IM Read --Add unit test for multiple overlapped path Restyled by clang-format Restyled by clang-format
Problem
Need to remove duplicate path if read request has multiple overlapped paths.
Change overview
--Remove duplicate attribute paths if there are multiple overlapped path in read
attribute path for IM Read
Testing
--Add unit test for multiple overlapped path