-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TV SDK] Enable media commands #9429
Merged
woody-apple
merged 4 commits into
project-chip:master
from
lazarkov:feature/enable-media-commands
Sep 17, 2021
Merged
[TV SDK] Enable media commands #9429
woody-apple
merged 4 commits into
project-chip:master
from
lazarkov:feature/enable-media-commands
Sep 17, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
chrisdecenzo,
jelderton,
jmartinez-silabs,
LuDuda,
mspang,
pan-apple,
saurabhst,
selissia and
woody-apple
September 2, 2021 14:22
lazarkov
force-pushed
the
feature/enable-media-commands
branch
3 times, most recently
from
September 2, 2021 18:42
46fc2b3
to
e1a5d9c
Compare
jmartinez-silabs
approved these changes
Sep 7, 2021
woody-apple
approved these changes
Sep 13, 2021
lazarkov
force-pushed
the
feature/enable-media-commands
branch
from
September 17, 2021 09:45
e1a5d9c
to
86e6cb1
Compare
pullapprove
bot
requested review from
erjiaqing,
hawk248,
holbrookt,
kghost,
kpschoedel,
msandstedt,
robszewczyk and
turon
September 17, 2021 09:46
Size increase report for "esp32-example-build" from dddd5d1
Full report output
|
ghost
approved these changes
Sep 17, 2021
jmartinez-silabs
approved these changes
Sep 17, 2021
chrisdecenzo
approved these changes
Sep 17, 2021
mleisner
pushed a commit
to mleisner/connectedhomeip
that referenced
this pull request
Sep 20, 2021
* Enable media attributes * Run zap regen command * Add media playback attributes to all-clusters app so tests can pass * Run zap_regen tool to generate code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Media Playback attributes are not enabled
Change overview
controller.zap
all-clusters.zap
endpoint 1 media playback cluster attributeszap_regen.sh
script to generate necessary filesTesting
./scripts/tests/test_suites.sh -a tv