Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TV SDK] Enable media commands #9429

Merged
merged 4 commits into from
Sep 17, 2021
Merged

[TV SDK] Enable media commands #9429

merged 4 commits into from
Sep 17, 2021

Conversation

lazarkov
Copy link
Contributor

@lazarkov lazarkov commented Sep 2, 2021 •
edited
Loading

Problem

Media Playback attributes are not enabled

Change overview

  • Enabled all available media playback commands via controller.zap
  • Updated typo in media-playback.xml
  • Enabled on the all-clusters.zap endpoint 1 media playback cluster attributes
  • Run zap_regen.sh script to generate necessary files

Testing

  • Run the ./scripts/tests/test_suites.sh -a tv

@lazarkov lazarkov force-pushed the feature/enable-media-commands branch 3 times, most recently from 46fc2b3 to e1a5d9c Compare September 2, 2021 18:42
@woody-apple
Copy link
Contributor

@saurabhst @msandstedt ?

@github-actions
Copy link

Size increase report for "esp32-example-build" from dddd5d1

File Section File VM
chip-all-clusters-app.elf .flash.rodata 184 184
chip-all-clusters-app.elf .dram0.bss 0 56
chip-all-clusters-app.elf .dram0.heap_start 0 -8
Full report output 
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-all-clusters-app.elf and ./pull_artifact/chip-all-clusters-app.elf:

sections,vmsize,filesize
.flash.rodata,184,184
.dram0.bss,56,0
.debug_str,0,26
.riscv.attributes,0,2
.dram0.heap_start,-8,0
[Unmapped],0,-184

@lazarkov lazarkov self-assigned this Sep 17, 2021
@lazarkov lazarkov added the TE6 label Sep 17, 2021
@franck-apple franck-apple added this to the Test Event 6 milestone Sep 17, 2021
@woody-apple woody-apple merged commit 412441a into project-chip:master Sep 17, 2021
mleisner pushed a commit to mleisner/connectedhomeip that referenced this pull request Sep 20, 2021
@lazarkov
[TV SDK] Enable media commands (project-chip#9429)
3516a1d 
* Enable media attributes

* Run zap regen command

* Add media playback attributes to all-clusters app so tests can pass

* Run zap_regen tool to generate code
@lazarkov lazarkov deleted the feature/enable-media-commands branch December 23, 2021 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@woody-apple woody-apple woody-apple approved these changes

@chrisdecenzo chrisdecenzo chrisdecenzo approved these changes

@jmartinez-silabs jmartinez-silabs jmartinez-silabs approved these changes

@andy31415 andy31415 Awaiting requested review from andy31415

@jelderton jelderton Awaiting requested review from jelderton

@LuDuda LuDuda Awaiting requested review from LuDuda

@mspang mspang Awaiting requested review from mspang

@pan-apple pan-apple Awaiting requested review from pan-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@austinh0 austinh0 Awaiting requested review from austinh0

@cecille cecille Awaiting requested review from cecille

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@hawk248 hawk248 Awaiting requested review from hawk248

@holbrookt holbrookt Awaiting requested review from holbrookt

@kghost kghost Awaiting requested review from kghost

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@msandstedt msandstedt Awaiting requested review from msandstedt

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@turon turon Awaiting requested review from turon

Assignees

@lazarkov lazarkov

Labels
app controller darwin examples review - approved
Projects
None yet
Milestone
Test Event 6
Development

Successfully merging this pull request may close these issues.
5 participants
@lazarkov @woody-apple @chrisdecenzo @jmartinez-silabs @franck-apple