Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eliminate ChildAdmissionController after dropping support for Kueue 0.6 #162

Closed
dgrove-oss opened this issue Jun 20, 2024 · 1 comment · Fixed by #186
Closed

Eliminate ChildAdmissionController after dropping support for Kueue 0.6 #162

dgrove-oss opened this issue Jun 20, 2024 · 1 comment · Fixed by #186

Comments

@dgrove-oss
Copy link
Collaborator

dgrove-oss commented Jun 20, 2024

The ChildAdmissionController was a hacky workaround for Kueue 0.6 not correctly recognizing external frameworks.

We contributed upstream enhancements (kubernetes-sigs/kueue#2059) that are included in Kueue 0.7 that make this workaround obsolete. Once we can drop support for Kueue 0.6 from the main branch, we should remove this controller and related configuration and documentation (including controller architecture description in webpages).

Need to wait for #161 to be merged to main before doing this.

@dgrove-oss
Copy link
Collaborator Author

#185 updates our controller architecture description for Kueue 0.7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant