-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for registering externally managed frameworks #2059
Add support for registering externally managed frameworks #2059
Conversation
Welcome @dgrove-oss! |
Hi @dgrove-oss. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
✅ Deploy Preview for kubernetes-sigs-kueue canceled.
|
/ok-to-test As a user-facing change, please add a release note. |
81b1546
to
35e25a9
Compare
Updated to address review comments. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the feedback; hopefully all addressed.
/test pull-kueue-test-unit-main |
The operation of parsing a kindArg into a GVK is deterministic. Since unit tests run multiple times, flagging these as errors will result in spurious failures in main_test's TestValidateIntegrationsName.
/lgtm |
LGTM label has been added. Git tree hash: 33f774c54cffa429a94882bc2a061f4136fb6bc3
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alculquicondor, dgrove-oss The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
What this PR does / why we need it:
Adds the ability to register GroupVersionKinds as being managed by an external Kueue workload controller.
This allows instances of these GVKs to be properly recognized as being managed by Kueue and
enables the instance's owned Jobs to be recognized as being child Jobs.
Which issue(s) this PR fixes:
Fixes #2003
Special notes for your reviewer:
Does this PR introduce a user-facing change?