Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test support: return default status if Route is not initialized #238

Merged
merged 1 commit into from
Aug 17, 2023

Conversation

sutaakar
Copy link
Contributor

@sutaakar sutaakar commented Aug 17, 2023

Issue link

What changes have been made

Minor fix to prevent e2e tests from failing in case Route initialization takes some time.

Verification steps

N/A
(Maybe there should be unit tests for test support package...)

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • Testing is not required for this change

@anishasthana
Copy link
Member

/lgtm

@openshift-ci
Copy link

openshift-ci bot commented Aug 17, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: anishasthana

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit be0dd48 into project-codeflare:main Aug 17, 2023
@sutaakar sutaakar deleted the route-fix branch August 17, 2023 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants