Add scorecard to ci #241
Add scorecard to ci #241
Conversation
dimakis
force-pushed
the
add-scorecard-to-ci
branch
from
1bf2fbb
to
65d41a4
Compare
.github/workflows/olm_tests.yaml
Outdated
| run: | | ||
| yq e 'del(.stages[].tests[] | select(.labels.test == "olm-crds-have-resources-test"))' -i bundle/tests/scorecard/config.yaml | ||
|
|
||
| - name: Scorecard check |
There was a problem hiding this comment.
Thinking whether it would have sense to move this test into separate workflow, as it is not related to OLM install or upgrade testing.
There was a problem hiding this comment.
I agree that moving it to a separate workflow makes sense
There was a problem hiding this comment.
it does, but I had it here to try and reduce time, moving it to its own workflow means we'd have to build it again.
no issue either way really, I just hate doing things twice when there is no need
dimakis
force-pushed
the
add-scorecard-to-ci
branch
2 times, most recently
from
37b547c
to
6bedfc8
Compare
dimakis
force-pushed
the
add-scorecard-to-ci
branch
3 times, most recently
from
dacf529
to
05ef655
Compare
dimakis
force-pushed
the
add-scorecard-to-ci
branch
from
05ef655
to
bfa2cca
Compare
dimakis
force-pushed
the
add-scorecard-to-ci
branch
from
bfa2cca
to
467b461
Compare
|
@anishasthana can you LGTM this, you're requested changes have been implemented |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: anishasthana The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
Issue link
Closes #205
What changes have been made
Addition of operator-sdk scorecard check to the CI and make target.
I've had to remove a failing test,
olm-crds-have-resources-testfrom the CI. This appears to be a known bugVerification steps
Look at CI run
Checks