Raise Kueue version in CodeFlare operator #628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgrove-oss
reviewed
Nov 15, 2024
| @@ -12,7 +12,7 @@ require ( | |||
| github.com/openshift/client-go v0.0.0-20221019143426-16aed247da5c | |||
| github.com/project-codeflare/appwrapper v0.27.0 | |||
| github.com/project-codeflare/codeflare-common v0.0.0-20240930133152-11fd6e3be6b3 | |||
| github.com/ray-project/kuberay/ray-operator v1.1.1 | |||
| github.com/ray-project/kuberay/ray-operator v1.2.1 | |||
There was a problem hiding this comment.
This is brought by Kueue 0.8.3 dependency. That is why I had to rewrite it below.
dgrove-oss
reviewed
Nov 15, 2024
sutaakar
force-pushed
the
appwrapper-original
branch
from
a39eea3
to
97a2239
Compare
sutaakar
changed the title
sutaakar
force-pushed
the
appwrapper-original
branch
from
7437b9b
to
0a48f8b
Compare
4 tasks
sutaakar
force-pushed
the
appwrapper-original
branch
from
0a48f8b
to
a70384c
Compare
|
@dgrove-oss Please take a look. |
astefanutti
approved these changes
Nov 20, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: astefanutti The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 2973dec
into
project-codeflare:main
8 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue link
N/A
What changes have been made
Raise Kueue version in CodeFlare operator to use latest Kueue dependency available in ODH.
Verification steps
E2E tests pass.
Checks