Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable tests based on CPU resource accounting #83

Merged
merged 4 commits into from
Dec 8, 2023

Conversation

dgrove-oss
Copy link
Collaborator

  1. Measure cluster capacity before starting test suite.
  2. Express CPU resource requests in test cases in terms of fractions of cluster capacity
  3. Start consolidating deployment configurations in aw_fixtures.
  4. Misc small test cleanups.

To validate that the tests are now not sensitive to cluster size I tested by limiting Rancher Desktop on my laptop to 2, 4, and 8 CPUs and observing tests ran correctly on all three sizes of kind clusters.

@dgrove-oss
Copy link
Collaborator Author

dgrove-oss commented Dec 7, 2023

Might be easier to review commit by commit since 4d0b961 just moved functions around without changing them.

Copy link
Member

@tardieu tardieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. As discussed orally, it would be good to share the cluster capacity computation between the controller and the test code in another PR.

@tardieu tardieu merged commit 6c43233 into project-codeflare:main Dec 8, 2023
1 check passed
@dgrove-oss dgrove-oss deleted the priority branch December 8, 2023 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants