Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: added context to error #620

Merged
merged 2 commits into from
May 13, 2024

Conversation

prakrit55
Copy link
Contributor

  • added more context to the error message found while patching with wrong image reference

Closes #396

Signed-off-by: Griffin <prakritimandal611@gmail.com>
Copy link

codecov bot commented May 11, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 33.81%. Comparing base (2602d59) to head (dae6b96).
Report is 64 commits behind head on main.

❗ Current head dae6b96 differs from pull request most recent head 2cbd179. Consider uploading reports for the commit 2cbd179 to get more accurate results

Files Patch % Lines
pkg/patch/patch.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #620      +/-   ##
==========================================
+ Coverage   32.51%   33.81%   +1.30%     
==========================================
  Files          17       18       +1     
  Lines        1621     1514     -107     
==========================================
- Hits          527      512      -15     
+ Misses       1062      969      -93     
- Partials       32       33       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@ashnamehrotra ashnamehrotra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@ashnamehrotra ashnamehrotra merged commit e280d5e into project-copacetic:main May 13, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[REQ] Provide more meaningful error messages
2 participants