ci: add CODECOV_TOKEN field to upload coverage #641
Conversation
Signed-off-by: ashnamehrotra <ashnamehrotra@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #641 +/- ##
==========================================
+ Coverage 32.51% 34.20% +1.69%
==========================================
Files 17 18 +1
Lines 1621 1523 -98
==========================================
- Hits 527 521 -6
+ Misses 1062 969 -93
- Partials 32 33 +1 ☔ View full report in Codecov by Sentry. |
| @@ -50,6 +50,8 @@ jobs: | |||
| run: make test | |||
| - name: Upload coverage to Codecov | |||
| uses: codecov/codecov-action@125fc84a9a348dbcf27191600683ec096ec9021c # v4.4.1 | |||
| env: | |||
| CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }} | |||
There was a problem hiding this comment.
We can't add this here, as forks do not have access to secrets.
afaik we don't need codecov token for public repositories: https://about.codecov.io/blog/tokenless-uploads-for-github-actions/
There was a problem hiding this comment.
it looks like they in the new release of codecov it is unsupported (https://github.com/codecov/codecov-action/releases/tag/v4.0.0), but forks will not need access?
There was a problem hiding this comment.
To quote one line of the CodeCov release that Ashna linked:
Tokenless uploading is unsupported. However, PRs made from forks to the upstream public repos will support tokenless (e.g. contributors to OS projects do not need the upstream repo's Codecov token). This doc shows instructions on how to add the Codecov token.
So it looks like this repo can add the CodeCov token and it should be fine that nobody's forks will have access to it.
|
Added CODECOV_TOKEN to repo |
Describe the changes in this pull request using active verbs such as Add, Remove, Replace ...
Closes #<issue_ID>