Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow change to BINS_OUT_DIR in makefile #678

Merged
merged 2 commits into from
Jun 26, 2024

Conversation

ashnamehrotra
Copy link
Contributor

Allow BINS_OUT_DIR in Makefile to be configured during call.

Describe the changes in this pull request using active verbs such as Add, Remove, Replace ...

Closes #<issue_ID>

Signed-off-by: ashnamehrotra <ashnamehrotra@gmail.com>
Copy link

codecov bot commented Jun 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 34.20%. Comparing base (2602d59) to head (3ba19d2).
Report is 91 commits behind head on main.

Current head 3ba19d2 differs from pull request most recent head 4f680f4

Please upload reports for the commit 4f680f4 to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #678      +/-   ##
==========================================
+ Coverage   32.51%   34.20%   +1.69%     
==========================================
  Files          17       18       +1     
  Lines        1621     1523      -98     
==========================================
- Hits          527      521       -6     
+ Misses       1062      969      -93     
- Partials       32       33       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ashnamehrotra ashnamehrotra merged commit 2366c37 into project-copacetic:main Jun 26, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants