We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The ICMP specification indicates that there should be a number of unused bits for some messages.
The number of unused bits vary:
The current ICMP.3d spec specifies these as byte fields not bit fields:
typedef struct _UNUSED_BYTES (UINT32 len) { ZeroByte Bytes[len]; } UNUSED_BYTES;
For example in parameter problem:
typedef struct _PARAMETER_PROBLEM_MESSAGE { UINT8 Code { Code == 0 }; UINT16BE Checksum; UINT8 Pointer; //Valid only if code is 0, is there something to check? UNUSED_BYTES(24) Unused; IP_HEADER_AND_DATAGRAM OriginalMsg; } PARAMETER_PROBLEM_MESSAGE;
Or in Source quench:
typedef struct _SOURCE_QUENCH_MESSAGE { UINT8 Code { Code == 0 }; UINT16BE Checksum; UNUSED_BYTES(32) Unused; IP_HEADER_AND_DATAGRAM OriginalMsg; } SOURCE_QUENCH_MESSAGE;
The 3d code could be modified to:
typedef struct _SOURCE_QUENCH_MESSAGE { ... UINT32BE Unused; .... }
And
typedef struct _PARAMETER_PROBLEM_MESSAGE { ... UINT8 Unused[3]; .... }
The text was updated successfully, but these errors were encountered:
d5b78b6
Merge pull request #113 from lemmy/mku-gh103
4be6deb
Fixes #103
No branches or pull requests
The ICMP specification indicates that there should be a number of unused bits for some messages.
The number of unused bits vary:
The current ICMP.3d spec specifies these as byte fields not bit fields:
For example in parameter problem:
Or in Source quench:
The 3d code could be modified to:
And
The text was updated successfully, but these errors were encountered: