EverParse3d.InputStream.Extern.fst: fix proof regression #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We have not been using hints in EverParse. The proofs have generally been stable without them. |
mtzguido
added a commit
to mtzguido/FStar
that referenced
this pull request
Nov 28, 2023
See project-everest/everparse#114 for an example of the error, visible only via --hint_info or --query_stats. This adds a separate error if that happens.
I claim #115 should make this proof much more robust. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This proof regressed again. I tried to stabilize it by splittin queries, but ran into this:
which is a z3 bug. To work around it I also added --z3refresh, and now this works reliably, albeit slowly.
I wanted to add hints but noticed there are none in the repo?