Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warnings and documentation for "at-most" constructs #128

Merged
merged 3 commits into from
Jan 22, 2024

Conversation

tahina-pro
Copy link
Member

This PR is a partial solution to #124 :

  • It fixes the deprecation warning raised by things like T t[<= n], now directing to use [:byte-size-single-element-array-at-most instead of the non-existing [:byte-size-at-most
  • It fixes the documentation wrt. the semantics of T [:byte-size-single-element-array-at-most n] : we validate the format of T and check that it fits within n bytes, and then we always consume exactly n bytes by advancing the position of the parser. So, this in effect allows one to encode an element T padded out to n bytes.
  • It turns the warning raised by T x[n] with sizeof(T) <> 1 into an error.

@tahina-pro tahina-pro merged commit 36b7b46 into master Jan 22, 2024
4 checks passed
@tahina-pro tahina-pro deleted the _taramana_3d_up_to branch October 25, 2024 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant