3d: weaken allow_reading for entrypoints #142
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consider the following 3D data format description:
From this definition, currently, 3D generates F* code that does not typecheck, because entrypoints are not supposed to have a reader, and the way we currently enforce this requirement is to forbid such definitions.
This PR relaxes this requirement to allow those definitions, by casting entrypoint validators with
validate_drop
to weaken their types.