Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3d: weaken allow_reading for entrypoints #142

Merged
merged 1 commit into from
Aug 9, 2024

Conversation

tahina-pro
Copy link
Member

Consider the following 3D data format description:

entrypoint typedef struct _test {
  UINT16 x;
} test;

From this definition, currently, 3D generates F* code that does not typecheck, because entrypoints are not supposed to have a reader, and the way we currently enforce this requirement is to forbid such definitions.

This PR relaxes this requirement to allow those definitions, by casting entrypoint validators with validate_drop to weaken their types.

@tahina-pro tahina-pro merged commit 13688df into master Aug 9, 2024
4 checks passed
@tahina-pro tahina-pro deleted the _taramana_3d_no_readable_entrypoint branch August 9, 2024 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant