Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Output types: ExternalAPI, ExternalTypes, and Makefile generation #90

Merged
merged 32 commits into from
Feb 8, 2023

Conversation

tahina-pro
Copy link
Member

With @aseemr and @nikswamy

Also includes:

  • Case change for type names generated by 3d: EVERPARSE_INPUT_STREAM_BASE instead of EverParseInputStreamBase
  • --(no_)emit_output_types_defs
  • --add_include to add a #include directive to all generated .c and .h files

aseemr and others added 27 commits January 18, 2023 14:06
@nikswamy
Copy link
Contributor

nikswamy commented Feb 7, 2023

FYI, the --cleanup option does not clean up the ExternalTypes.krml and ExternalAPI.krml files

@nikswamy
Copy link
Contributor

nikswamy commented Feb 7, 2023

I also see these krml warnings

Warning 24: EverParse3d.ErrorCode.is_error is marked [@cinline] and also covered by a -static-header krml option... the [@cinline] is redundant because -static-header generates code marked as static inline
Warning 24: EverParse3d.ErrorCode.is_success is marked [@cinline] and also covered by a -static-header krml option... the [@cinline] is redundant because -static-header generates code marked as static inline
Warning 24: EverParse3d.ErrorCode.set_validator_error_pos is marked [@cinline] and also covered by a -static-header krml option... the [@cinline] is redundant because -static-header generates code marked as static inline
Warning 24: EverParse3d.ErrorCode.get_validator_error_kind is marked [@cinline] and also covered by a -static-header krml option... the [@cinline] is redundant because -static-header generates code marked as static inline
Warning 24: EverParse3d.ErrorCode.check_constraint_ok is marked [@cinline] and also covered by a -static-header krml option... the [@cinline] is redundant because -static-header generates code marked as static inline
Warning 24: EverParse3d.Prelude.StaticHeader.get_bitfield8 is marked [@cinline] and also covered by a -static-header krml option... the [@cinline] is redundant because -static-header generates code marked as static inline

@tahina-pro tahina-pro merged commit cd7dde1 into master Feb 8, 2023
@tahina-pro tahina-pro deleted the _aseem_output_types_modules branch March 28, 2023 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants