F*+dune: new F* library layout, improved handling of FSTAR_HOME #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a companion to FStarLang/FStar#2815
With F* being built with
dune, its library is now organized differently:fstar-lib,fstar-compiler-libandfstar-tactics-libare now merged intofstar.liblocated in$FSTAR_HOME/lib/fstar/lib/fstar_lib.cmx*instead of$FSTAR_HOME/bin/*.cmx*So this PR fixes the dune builds for qd.exe and 3d.exe accordingly. In this process, FStar_Getopt.ml need no longer be copied from the F* sources, since it is already implemented in fstar.libThis PR also improves the handling of the
FSTAR_HOMEenvironment variable in Makefiles, so that EverParse can now be compiled and tested even if F* is installed from opam (or withmake install), withfstar.exein thePATH, so that the user need no longer setFSTAR_HOMEin such cases.I have an Everest branch reporting green CI (cf. project-everest/everest@9250435) with this PR and the corresponding F* and Karamel PRs (FStarLang/karamel#333)