Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FhirValueSetEnumInterface and system OIDs #153

Closed
qligier opened this issue Jul 17, 2024 · 1 comment · Fixed by #160
Closed

FhirValueSetEnumInterface and system OIDs #153

qligier opened this issue Jul 17, 2024 · 1 comment · Fixed by #160
Assignees
Labels
bug Something isn't working

Comments

@qligier
Copy link
Member

qligier commented Jul 17, 2024

When value sets are generated, the system may be an OID. In that case, it is not URN-encoded. I removed the URN-encoding in eMed value sets in c029d01 (RouteOfAdministrationEdqm was the last one), the EPR value sets were never affected by the URN-encoding.

The issue is that the implementation of Coding getCoding() and boolean isEqualTo(Coding) (from FhirValueSetEnumInterface) do not add or remove the URN-encoding, as required by the FHIR specification.

@qligier qligier added the bug Something isn't working label Jul 17, 2024
@qligier qligier self-assigned this Jul 17, 2024
@qligier
Copy link
Member Author

qligier commented Jul 17, 2024

Also, in getCodeableConcept(), we set the wrong value in the text. Currently, we use the code system name instead of the code display name.
It's a different issue for the generator, but will be solved in the same PR for Husky.

qligier added a commit that referenced this issue Jul 18, 2024
qligier added a commit that referenced this issue Jul 18, 2024
qligier added a commit that referenced this issue Jul 18, 2024
qligier added a commit to project-husky/code-generator that referenced this issue Jul 18, 2024
@qligier qligier linked a pull request Jul 18, 2024 that will close this issue
qligier added a commit to project-husky/code-generator that referenced this issue Jul 18, 2024
qligier added a commit that referenced this issue Jul 18, 2024
qligier added a commit to project-husky/code-generator that referenced this issue Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant