Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix build flag path #271

Merged
merged 1 commit into from
Jan 18, 2024
Merged

fix build flag path #271

merged 1 commit into from
Jan 18, 2024

Conversation

maskarb
Copy link
Member

@maskarb maskarb commented Jan 17, 2024

The controllers directory moved from the root folder into internal and its name was changed to controller. The build flag that inserts the GitCommit is updated in this PR to match the new repo layout.

Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

codecov bot commented Jan 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2e2a476) 85.12% compared to head (0a266b0) 85.12%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #271   +/-   ##
=======================================
  Coverage   85.12%   85.12%           
=======================================
  Files          13       13           
  Lines        2730     2730           
=======================================
  Hits         2324     2324           
  Misses        325      325           
  Partials       81       81           
Flag Coverage Δ
unittests 85.12% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e2a476...0a266b0. Read the comment docs.

@maskarb maskarb merged commit ee9edbc into main Jan 18, 2024
7 checks passed
@maskarb maskarb deleted the fix-build-flag branch January 18, 2024 04:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants