Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make downstream v3.2.1 #313

Merged
merged 1 commit into from
Mar 18, 2024
Merged

make downstream v3.2.1 #313

merged 1 commit into from
Mar 18, 2024

Conversation

maskarb
Copy link
Member

@maskarb maskarb commented Mar 18, 2024

No description provided.

Copy link

codecov bot commented Mar 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.84%. Comparing base (af2669a) to head (6a15240).

Additional details and impacted files

Impacted file tree graph

@@                  Coverage Diff                  @@
##           downstream-v3.2.1     #313      +/-   ##
=====================================================
- Coverage              85.13%   84.84%   -0.30%     
=====================================================
  Files                     13       13              
  Lines                   2731     2731              
=====================================================
- Hits                    2325     2317       -8     
- Misses                   325      331       +6     
- Partials                  81       83       +2     
Flag Coverage Δ
unittests 84.84% <ø> (-0.30%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
internal/crhchttp/http_cloud_dot_redhat.go 0.00% <ø> (ø)
internal/packaging/packaging.go 79.58% <ø> (ø)

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af2669a...6a15240. Read the comment docs.

@maskarb maskarb force-pushed the make-downstream-v3.2.1 branch from dba1532 to 6a15240 Compare March 18, 2024 16:28
Copy link
Contributor

@djnakabaale djnakabaale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick question:

Did we intend to change occurrences of koku-metrics-operator to costmanagement-metrics-operator in all these docs?

docs/cr-example.md

docs/local-development.md

docs/release-testing.md

docs/releasing.md

@maskarb
Copy link
Member Author

maskarb commented Mar 18, 2024

nitpick question:

Did we intend to change occurrences of koku-metrics-operator to costmanagement-metrics-operator in all these docs?

docs/cr-example.md

docs/local-development.md

docs/release-testing.md

docs/releasing.md

No, but these files are unused, so they don't have any impact on the downstream code.

@maskarb maskarb merged commit caec017 into downstream-v3.2.1 Mar 18, 2024
10 checks passed
@maskarb maskarb deleted the make-downstream-v3.2.1 branch March 18, 2024 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants