Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

correct CSV name in make downstream #319

Merged
merged 1 commit into from
Mar 19, 2024
Merged

Conversation

maskarb
Copy link
Member

@maskarb maskarb commented Mar 19, 2024

We don't include the version v in the name of the ClusterServiceVersion downstream. This PR fixes the make downstream command to overwrite the CSV name. spec.replaces and the metadata.name must match, else upgrades won't work. This PR ensures their formats remain consistent.

Copy link

codecov bot commented Mar 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.13%. Comparing base (b2f892c) to head (64ac08b).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #319   +/-   ##
=======================================
  Coverage   85.13%   85.13%           
=======================================
  Files          13       13           
  Lines        2731     2731           
=======================================
  Hits         2325     2325           
  Misses        325      325           
  Partials       81       81           
Flag Coverage Δ
unittests 85.13% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b2f892c...64ac08b. Read the comment docs.

@maskarb maskarb merged commit 42d123a into main Mar 19, 2024
10 checks passed
@maskarb maskarb deleted the update-downstream-makefile branch March 19, 2024 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants