Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[COST-1665] add node to storage reports #99

Merged
merged 7 commits into from
Apr 18, 2024

Conversation

adberglund
Copy link
Contributor

@adberglund adberglund commented Jul 14, 2021

JIRA Issue:

COST-1665

Summary

This would add the node from the kubelet_volume_stats to the storage report.

@adberglund adberglund self-assigned this Jul 14, 2021
@codecov
Copy link

codecov bot commented Jul 14, 2021

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.09%. Comparing base (35df228) to head (08e7b29).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #99      +/-   ##
==========================================
+ Coverage   86.08%   86.09%   +0.01%     
==========================================
  Files          13       13              
  Lines        2163     2165       +2     
==========================================
+ Hits         1862     1864       +2     
  Misses        220      220              
  Partials       81       81              
Flag Coverage Δ
unittests 86.09% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
internal/collector/types.go 100.00% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 35df228...08e7b29. Read the comment docs.

@adberglund adberglund requested a review from a team July 14, 2021 19:05
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@maskarb maskarb force-pushed the cost-1665-node-in-storage-report branch from 0815424 to 076d8bb Compare April 18, 2024 17:22
@maskarb maskarb changed the title Add node to storage reports [COST-1665] add node to storage reports Apr 18, 2024
Copy link
Contributor

@djnakabaale djnakabaale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍🏾

@maskarb maskarb merged commit 87f86f7 into main Apr 18, 2024
10 checks passed
@maskarb maskarb deleted the cost-1665-node-in-storage-report branch April 18, 2024 18:32
@adberglund
Copy link
Contributor Author

@maskarb 🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants