Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[COST-5637] Change tag exclusions to an or operation for openshift-virt #5388

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

myersCody
Copy link
Contributor

Jira Ticket

[COST-5637(https://issues.redhat.com/browse/COST-5637)

Description

This change will change the operation we use for tag exclusions for the OpenShift virtualization endpoint.

Testing

  1. Check out branch
  2. Load test customer data for on prem
  3. Enable the exclude & excluded tag key through the settings
  4. Resummarize on prem source.
  5. Hit this endpoint and notice the key,value pairs are excluded from the return:
  1. Go to main and realize nothing is returned.

Release Notes

  • proposed release note
* [COST-5637](https://issues.redhat.com/browse/COST-5637) Tweak multiple tag key value pair exclusion logic

Copy link

codecov bot commented Nov 18, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 94.1%. Comparing base (3fb15b9) to head (3e2f161).

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #5388   +/-   ##
=====================================
  Coverage   94.1%   94.1%           
=====================================
  Files        371     371           
  Lines      31547   31549    +2     
  Branches    3384    3385    +1     
=====================================
+ Hits       29678   29680    +2     
- Misses      1210    1211    +1     
+ Partials     659     658    -1     
---- 🚨 Try these New Features:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant