Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close Terminal in App #453

Merged
merged 1 commit into from
Sep 11, 2020
Merged

Conversation

dwalluck
Copy link
Contributor

@dwalluck dwalluck commented Sep 11, 2020

This came from an upstream picocli example, which I have fixed upstream, see remkop/picocli#1168 and remkop/picocli#1169.

@rnc
Copy link
Contributor

rnc commented Sep 11, 2020

LGTM

@codecov
Copy link

codecov bot commented Sep 11, 2020

Codecov Report

Merging #453 into master will increase coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##             master    #453   +/-   ##
========================================
  Coverage      5.48%   5.48%           
  Complexity      103     103           
========================================
  Files           133     133           
  Lines          4995    4994    -1     
  Branches        463     463           
========================================
  Hits            274     274           
+ Misses         4702    4701    -1     
  Partials         19      19           
Impacted Files Coverage Δ Complexity Δ
cli/src/main/java/org/jboss/pnc/bacon/cli/App.java 40.27% <0.00%> (+0.55%) 10.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e4a806...9d91592. Read the comment docs.

@dwalluck dwalluck merged commit 4e0a9ea into project-ncl:master Sep 11, 2020
@dwalluck dwalluck deleted the app-close-terminal branch September 11, 2020 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants