Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NCL-6462: Sort dumpCurrentConfig output by key #282

Merged
merged 1 commit into from
Apr 25, 2021

Conversation

dwalluck
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Apr 22, 2021

Codecov Report

Merging #282 (18cef1c) into master (5154b3e) will increase coverage by 0.20%.
The diff coverage is 92.30%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #282      +/-   ##
============================================
+ Coverage     68.62%   68.82%   +0.20%     
  Complexity      389      389              
============================================
  Files            44       44              
  Lines          1877     1880       +3     
  Branches        258      256       -2     
============================================
+ Hits           1288     1294       +6     
+ Misses          478      476       -2     
+ Partials        111      110       -1     
Impacted Files Coverage Δ Complexity Δ
...c/main/java/org/jboss/gm/common/Configuration.java 92.00% <92.30%> (-3.24%) 6.00 <3.00> (ø)
...org/jboss/gm/analyzer/alignment/AlignmentTask.java 92.64% <0.00%> (+0.47%) 86.00% <0.00%> (ø%)
.../gm/manipulation/actions/ManifestUpdateAction.java 58.33% <0.00%> (+4.16%) 9.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5154b3e...18cef1c. Read the comment docs.

Copy link
Contributor

@rnc rnc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert the newline change

@dwalluck dwalluck force-pushed the NCL-6462 branch 5 times, most recently from b669712 to 77112d3 Compare April 24, 2021 15:03
@rnc rnc merged commit 57c263a into project-ncl:master Apr 25, 2021
@dwalluck dwalluck deleted the NCL-6462 branch April 29, 2021 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants