Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NCL-6601: Update for new REST endpoints #297

Merged
merged 1 commit into from
Jun 21, 2021
Merged

Conversation

dwalluck
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Jun 18, 2021

Codecov Report

Merging #297 (623c50e) into master (376dadd) will increase coverage by 0.12%.
The diff coverage is 96.42%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #297      +/-   ##
============================================
+ Coverage     68.88%   69.00%   +0.12%     
  Complexity      394      394              
============================================
  Files            44       44              
  Lines          1880     1881       +1     
  Branches        256      255       -1     
============================================
+ Hits           1295     1298       +3     
+ Misses          477      475       -2     
  Partials        108      108              
Impacted Files Coverage Δ
.../jboss/gm/analyzer/alignment/AlignmentService.java 77.77% <ø> (ø)
...c/main/java/org/jboss/gm/common/Configuration.java 92.00% <ø> (ø)
...main/java/org/jboss/gm/common/utils/RESTUtils.java 93.33% <ø> (-0.79%) ⬇️
...boss/gm/analyzer/alignment/DAAlignmentService.java 92.59% <94.11%> (+0.92%) ⬆️
...org/jboss/gm/analyzer/alignment/AlignmentTask.java 92.83% <100.00%> (ø)
...alyzer/alignment/DependencyOverrideCustomizer.java 90.62% <100.00%> (ø)
...jboss/gm/analyzer/alignment/io/SettingsFileIO.java 91.48% <100.00%> (ø)
...in/java/org/jboss/gm/common/utils/GroovyUtils.java 67.39% <100.00%> (ø)
.../org/jboss/gm/manipulation/ManipulationPlugin.java 42.22% <100.00%> (ø)
.../gm/manipulation/actions/ManifestUpdateAction.java 58.33% <0.00%> (+4.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 376dadd...623c50e. Read the comment docs.

@dwalluck dwalluck requested a review from rnc June 19, 2021 01:42
Copy link
Contributor

@rnc rnc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, thanks!

@rnc rnc merged commit 61d2add into project-ncl:master Jun 21, 2021
@dwalluck dwalluck deleted the NCL-6601 branch October 18, 2021 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants