Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Escape backslashes on Windows in repositories/flatDir/dirs #303

Merged
merged 1 commit into from
Jun 23, 2021

Conversation

dwalluck
Copy link
Contributor

No description provided.

@dwalluck
Copy link
Contributor Author

This is just a quick fix to make MainTest work with Windows paths.

Oddly, for dirs, using / doesn't seem to work either as Gradle thinks the path is relative, so you have to use a double backslash\\.

Also, it fixes another potential issue by using toUri() instead of getPath().

@codecov-commenter
Copy link

codecov-commenter commented Jun 22, 2021

Codecov Report

Merging #303 (e28b6ca) into master (43007d4) will increase coverage by 0.10%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #303      +/-   ##
============================================
+ Coverage     68.88%   68.98%   +0.10%     
  Complexity      393      393              
============================================
  Files            44       44              
  Lines          1880     1880              
  Branches        256      256              
============================================
+ Hits           1295     1297       +2     
+ Misses          477      475       -2     
  Partials        108      108              
Impacted Files Coverage Δ
.../gm/manipulation/actions/ManifestUpdateAction.java 58.33% <0.00%> (+4.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 43007d4...e28b6ca. Read the comment docs.

@dwalluck dwalluck requested a review from rnc June 22, 2021 22:45
@rnc
Copy link
Contributor

rnc commented Jun 23, 2021

Are we running this at all on Windows? I just wonder why we're going to the effort?

@rnc rnc merged commit 62b18d3 into project-ncl:master Jun 23, 2021
@dwalluck dwalluck deleted the main-test-fix-windows-dirs branch October 18, 2021 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants