NCL-7185: Ignore overrideTransitive if dependencySource=NONE #386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #386 +/- ##
============================================
+ Coverage 66.01% 66.07% +0.06%
Complexity 405 405
============================================
Files 41 41
Lines 2083 2084 +1
Branches 291 292 +1
============================================
+ Hits 1375 1377 +2
+ Misses 604 602 -2
- Partials 104 105 +1
Continue to review full report at Codecov.
|
dwalluck
commented
Jul 14, 2022
| @@ -592,11 +593,13 @@ private Map<RelaxedProjectVersionRef, ProjectVersionRef> getDependencies(Project | |||
| } | |||
| Set<ResolvedDependency> target; | |||
| if (internalConfig.overrideTransitive() == null || !internalConfig.overrideTransitive()) { | |||
There was a problem hiding this comment.
This is the original code, but it looks like this outer if was never necessary?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If GME detects the shadow plugin, it currently requires the user to explicitly set
overrideTransitive. However, ifdependencySource=NONE, then dependencies won't get aligned anyway, so I don't think the build should fail in that case.