Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NCLSUP-748 Override project version correctly #410

Merged
merged 1 commit into from
Sep 30, 2022
Merged

Conversation

rnc
Copy link
Contributor

@rnc rnc commented Sep 30, 2022

Thanks to @ebaron for the patch.

@codecov-commenter
Copy link

codecov-commenter commented Sep 30, 2022

Codecov Report

Base: 65.74% // Head: 65.86% // Increases project coverage by +0.12% 🎉

Coverage data is based on head (abcc1eb) compared to base (c73612a).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #410      +/-   ##
============================================
+ Coverage     65.74%   65.86%   +0.12%     
- Complexity      414      415       +1     
============================================
  Files            41       41              
  Lines          2160     2162       +2     
  Branches        310      311       +1     
============================================
+ Hits           1420     1424       +4     
+ Misses          631      629       -2     
  Partials        109      109              
Impacted Files Coverage Δ
...org/jboss/gm/analyzer/alignment/AlignmentTask.java 91.85% <100.00%> (+0.03%) ⬆️
.../gm/manipulation/actions/ManifestUpdateAction.java 46.03% <0.00%> (+3.17%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@rnc rnc merged commit c0f6457 into project-ncl:main Sep 30, 2022
@rnc rnc deleted the NCLSUP748 branch September 30, 2022 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants