Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NCLSUP-793 Auto-disable signing plugin. Handle strict resolution stra… #425

Merged
merged 2 commits into from
Dec 12, 2022

Conversation

rnc
Copy link
Contributor

@rnc rnc commented Dec 1, 2022

…tegy

@rnc rnc requested a review from dwalluck December 1, 2022 09:53
@rnc rnc force-pushed the NCLSUP793 branch 2 times, most recently from c0db1cf to bbc5671 Compare December 1, 2022 10:29
@codecov-commenter
Copy link

codecov-commenter commented Dec 9, 2022

Codecov Report

Base: 66.66% // Head: 65.42% // Decreases project coverage by -1.23% ⚠️

Coverage data is based on head (151d64a) compared to base (0a08638).
Patch coverage: 40.62% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #425      +/-   ##
============================================
- Coverage     66.66%   65.42%   -1.24%     
- Complexity      437      438       +1     
============================================
  Files            42       42              
  Lines          2259     2285      +26     
  Branches        329      331       +2     
============================================
- Hits           1506     1495      -11     
- Misses          637      691      +54     
+ Partials        116       99      -17     
Impacted Files Coverage Δ
.../org/jboss/gm/manipulation/ManipulationPlugin.java 4.31% <0.00%> (-24.27%) ⬇️
...n/java/org/jboss/gm/common/utils/ProjectUtils.java 86.20% <88.88%> (+1.20%) ⬆️
...org/jboss/gm/analyzer/alignment/AlignmentTask.java 91.59% <100.00%> (+0.12%) ⬆️
...in/java/org/jboss/gm/common/utils/PluginUtils.java 91.03% <100.00%> (+0.17%) ⬆️
.../gm/manipulation/actions/ManifestUpdateAction.java 46.03% <0.00%> (+3.17%) ⬆️
...g/jboss/gm/analyzer/alignment/AlignmentPlugin.java 100.00% <0.00%> (+4.34%) ⬆️
...g/jboss/gm/analyzer/alignment/util/Comparator.java 81.25% <0.00%> (+6.25%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@rnc rnc merged commit 5c37496 into project-ncl:main Dec 12, 2022
@rnc rnc deleted the NCLSUP793 branch December 12, 2022 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants