Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NCLSUP-800 Add BOM support #427

Merged
merged 3 commits into from
Dec 12, 2022
Merged

NCLSUP-800 Add BOM support #427

merged 3 commits into from
Dec 12, 2022

Conversation

rnc
Copy link
Contributor

@rnc rnc commented Dec 8, 2022

No description provided.

@rnc rnc requested a review from dwalluck December 8, 2022 15:25
@codecov-commenter
Copy link

codecov-commenter commented Dec 8, 2022

Codecov Report

Base: 65.94% // Head: 65.53% // Decreases project coverage by -0.40% ⚠️

Coverage data is based on head (4d92d49) compared to base (e30abea).
Patch coverage: 80.37% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #427      +/-   ##
============================================
- Coverage     65.94%   65.53%   -0.41%     
- Complexity      417      441      +24     
============================================
  Files            41       42       +1     
  Lines          2161     2304     +143     
  Branches        311      332      +21     
============================================
+ Hits           1425     1510      +85     
- Misses          626      692      +66     
+ Partials        110      102       -8     
Impacted Files Coverage Δ
...jboss/gm/analyzer/alignment/io/SettingsFileIO.java 92.06% <ø> (ø)
...c/main/java/org/jboss/gm/common/Configuration.java 92.00% <ø> (ø)
.../org/jboss/gm/manipulation/ManipulationPlugin.java 4.31% <0.00%> (-24.27%) ⬇️
...main/java/org/jboss/gm/common/utils/OTELUtils.java 45.00% <45.00%> (ø)
...jboss/gm/common/logging/FilteringCustomLogger.java 80.00% <50.00%> (-4.22%) ⬇️
...org/jboss/gm/analyzer/alignment/AlignmentTask.java 91.45% <86.66%> (-0.38%) ⬇️
...n/java/org/jboss/gm/common/utils/ProjectUtils.java 86.20% <88.88%> (+1.20%) ⬆️
...in/java/org/jboss/gm/common/utils/PluginUtils.java 91.03% <94.44%> (+2.63%) ⬆️
...g/jboss/gm/analyzer/alignment/AlignmentPlugin.java 95.65% <100.00%> (+0.91%) ⬆️
cli/src/main/java/org/jboss/gm/cli/Main.java 69.81% <100.00%> (-0.19%) ⬇️
... and 4 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@rnc rnc force-pushed the NCLSUP800 branch 2 times, most recently from 57b44f0 to 9ec982e Compare December 9, 2022 10:50
@rnc rnc merged commit 561a609 into project-ncl:main Dec 12, 2022
@rnc rnc deleted the NCLSUP800 branch December 12, 2022 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants