Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure NONE only disables alignment allowing version calculation to p… #429

Merged
merged 1 commit into from
Dec 13, 2022

Conversation

rnc
Copy link
Contributor

@rnc rnc commented Dec 12, 2022

…roceed

NCL-7467

@codecov-commenter
Copy link

codecov-commenter commented Dec 12, 2022

Codecov Report

Base: 65.94% // Head: 65.36% // Decreases project coverage by -0.57% ⚠️

Coverage data is based on head (96a50a7) compared to base (e30abea).
Patch coverage: 79.64% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #429      +/-   ##
============================================
- Coverage     65.94%   65.36%   -0.58%     
- Complexity      417      441      +24     
============================================
  Files            41       42       +1     
  Lines          2161     2307     +146     
  Branches        311      333      +22     
============================================
+ Hits           1425     1508      +83     
- Misses          626      696      +70     
+ Partials        110      103       -7     
Impacted Files Coverage Δ
...jboss/gm/analyzer/alignment/io/SettingsFileIO.java 92.06% <ø> (ø)
...c/main/java/org/jboss/gm/common/Configuration.java 92.00% <ø> (ø)
.../org/jboss/gm/manipulation/ManipulationPlugin.java 4.31% <0.00%> (-24.27%) ⬇️
...main/java/org/jboss/gm/common/utils/OTELUtils.java 45.00% <45.00%> (ø)
...jboss/gm/common/logging/FilteringCustomLogger.java 80.00% <50.00%> (-4.22%) ⬇️
...boss/gm/analyzer/alignment/DAAlignmentService.java 76.31% <66.66%> (-17.97%) ⬇️
...org/jboss/gm/analyzer/alignment/AlignmentTask.java 91.45% <86.66%> (-0.38%) ⬇️
...n/java/org/jboss/gm/common/utils/ProjectUtils.java 86.20% <88.88%> (+1.20%) ⬆️
...in/java/org/jboss/gm/common/utils/PluginUtils.java 91.03% <94.44%> (+2.63%) ⬆️
...g/jboss/gm/analyzer/alignment/AlignmentPlugin.java 100.00% <100.00%> (+5.26%) ⬆️
... and 8 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@rnc rnc merged commit ea58368 into project-ncl:main Dec 13, 2022
@rnc rnc deleted the NCL7467 branch December 13, 2022 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants