Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Google Cloud Build to upload artifacts #253

Merged
merged 1 commit into from
Oct 8, 2019
Merged

Conversation

tiziano88
Copy link
Collaborator

@tiziano88 tiziano88 commented Oct 7, 2019

Add an additional pipeline running on Google Cloud Build, which builds
the enclave binary and pushes it to Google Cloud Storage. The intention
is for this to be used to build reference binary artifacts to be
deployed on Borg in Google if necessary, once we get full reproducible
builds (#241).

Example run:
https://pantheon.corp.google.com/cloud-build/builds/700d7aea-6799-4822-afa1-ec3758e88faf?project=oak-ci

@tiziano88 tiziano88 force-pushed the tzn_cloud_build_2 branch 14 times, most recently from 7abbbb5 to f22c7b7 Compare October 7, 2019 20:25
@tiziano88 tiziano88 changed the title Test cloud build Use Google Cloud Build to upload artifacts Oct 7, 2019
@tiziano88 tiziano88 marked this pull request as ready for review October 7, 2019 20:28
@tiziano88 tiziano88 force-pushed the tzn_cloud_build_2 branch 2 times, most recently from d594986 to 1a8575c Compare October 8, 2019 09:19
cloudbuild.yaml Outdated
- name: 'gcr.io/cloud-builders/docker'
id: pull_image
waitFor: ['-']
timeout: 1h
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isn't this a bit too generous?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes.

id: move_artifacts
waitFor: ['build_code']
entrypoint: 'cp'
args: ['./bazel-bin/oak/server/asylo/oak_enclave_unsigned.so', './oak_enclave_unsigned.so']
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm... isn't there a way for bazel to specify the output of the binary instead of copying it?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not AFAICT.

timeout: 2h

options:
machineType: 'N1_HIGHCPU_8'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why 8? :)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

8 CPUs 😎

Add an additional pipeline running on Google Cloud Build, which builds
the enclave binary and pushes it to Google Cloud Storage. The intention
is for this to be used to build reference binary artifacts to be
deployed on Borg in Google if necessary, once we get full reproducible
builds (#241).

Always use Bazel cache for builds and for tests.

Example run:
https://pantheon.corp.google.com/cloud-build/builds/700d7aea-6799-4822-afa1-ec3758e88faf?project=oak-ci
@tiziano88 tiziano88 merged commit a757e76 into master Oct 8, 2019
@tiziano88 tiziano88 deleted the tzn_cloud_build_2 branch October 8, 2019 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants