Skip to content
This repository has been archived by the owner on Apr 9, 2024. It is now read-only.

Update image and README #221

Merged
merged 2 commits into from
Mar 24, 2023
Merged

Update image and README #221

merged 2 commits into from
Mar 24, 2023

Conversation

rbehjati
Copy link
Contributor

@rbehjati rbehjati commented Feb 6, 2023

Fixes #<issue_number_goes_here>

It's a good idea to open an issue first for discussion.

  • Tests pass
  • Appropriate changes to README are included in PR

@rbehjati
Copy link
Contributor Author

@mariaschett Can you have a quick look at this? This is mostly formatting, but I've added a new subsection in the README for Related work and standards. It is not complete, but I thought it could be a good start.

Copy link
Contributor

@mariaschett mariaschett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

ones in our design, but seems to be focused on claims and evidence that are generated and consumed
automatically. Claims and evidence in RATS are designed to be used for remote attestation. The
claims in our binary transparency ecosystem, however, are not limited to the ones used for remote
attestation. We target a wider range of use cases.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could be nice to give an example of a use case we target which RATS does not.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Done.

[Concise Reference Integrity Manifest (CoRIM)](https://datatracker.ietf.org/doc/draft-ietf-rats-corim/)
provided by the RATS working group is very similar to a `Claim` as described in this document.

TODO: Summarize the comparison.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall we add a TODO(#?)?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.


### Comparison to SCITT

TBA.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall we add a TODO(#?)?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

Copy link
Contributor Author

@rbehjati rbehjati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the review :)

ones in our design, but seems to be focused on claims and evidence that are generated and consumed
automatically. Claims and evidence in RATS are designed to be used for remote attestation. The
claims in our binary transparency ecosystem, however, are not limited to the ones used for remote
attestation. We target a wider range of use cases.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Done.

[Concise Reference Integrity Manifest (CoRIM)](https://datatracker.ietf.org/doc/draft-ietf-rats-corim/)
provided by the RATS working group is very similar to a `Claim` as described in this document.

TODO: Summarize the comparison.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.


### Comparison to SCITT

TBA.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@rbehjati rbehjati merged commit f240303 into project-oak:main Mar 24, 2023
@rbehjati rbehjati deleted the docs branch March 24, 2023 15:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants