Migrate SlippiUser to be backed by a Rust layer #403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Forwards calls in and out of the Rust User Manager held by the EXI device. - Handles converting UserInfo into C++ types so that any existing logic relying on assumptions about the type doesn't need to be flagged just yet.
- Chat message importing for the current user, as well as the default chat list, now live over on the Rust side. - Slight edits to Matchmaking to handle how chat messages are loaded, solely to avoid extra string allocations. Tested and no issues found, but someone with more context should test again.
…ts WebView functionality and linking on macOS
NikhilNarayana
force-pushed
the
oxidation/user
branch
from
44077dc
to
3e858ec
Compare
NikhilNarayana
approved these changes
Sep 19, 2023
NikhilNarayana
force-pushed
the
oxidation/user
branch
from
86f436e
to
31c9339
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR goes hand-in-hand with project-slippi/slippi-rust-extensions#5: Initial scaffolding for porting User model .
The other PR has more info, but the overall gist here is:
SlippiUserhas a mostly-kept API to reduce churn, but gets a copy of the Rust EXI device pointer and its API just ferries in and out of the Rust layer. This is safe enough since we don't allow the user to outlive the EXI device.slprs_exi_device_createnow uses a config struct to make what we're passing over the boundary a little more clear.I've played on this branch for a few days now with no issues, but I of course invite any testing since there's definitely things I could've missed.
This should port relatively cleanly to the mainline branch, all things considered.