Migrate SlippiUser to be backed by a Rust layer #403
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR goes hand-in-hand with project-slippi/slippi-rust-extensions#5: Initial scaffolding for porting User model .
The other PR has more info, but the overall gist here is:
SlippiUser
has a mostly-kept API to reduce churn, but gets a copy of the Rust EXI device pointer and its API just ferries in and out of the Rust layer. This is safe enough since we don't allow the user to outlive the EXI device.slprs_exi_device_create
now uses a config struct to make what we're passing over the boundary a little more clear.I've played on this branch for a few days now with no issues, but I of course invite any testing since there's definitely things I could've missed.
This should port relatively cleanly to the mainline branch, all things considered.