Parse instance id info #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NickCondron
force-pushed
the
instance
branch
from
bc26b16
to
df54f98
Compare
|
Small PR hoping to get it merged now that the instance fields are released |
|
@NickCondron Do you mind adding a test and a minimal SLP (if an SLP containing the data to test doesn't already exist)? |
vinceau
approved these changes
Oct 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is intended to parse instance id data added by project-slippi/slippi-ssbm-asm#120
Here is what a ~10 second match against a CPU looks like when you print all the post-frame/item updates and their relevant instance id info:
https://pastebin.com/5zP8MdgB
As mentioned in the other PR these fields can be used to better track hits in doubles because lastHitBy field is unreliable (#71).