Skip to content
This repository has been archived by the owner on Dec 4, 2020. It is now read-only.

Standardized POS destinations of players at all Survival Guides #1395

Merged
merged 2 commits into from
Nov 4, 2020
Merged

Standardized POS destinations of players at all Survival Guides #1395

merged 2 commits into from
Nov 4, 2020

Conversation

EpicTaru
Copy link
Contributor

@EpicTaru EpicTaru commented Oct 19, 2020

This is to ensure that when a Survival Guide teleport is used, the player is placed directly next to a Guide (or ON the guide in navmesh limitations prohibit the placing next to the Guide).

Multiple times were noticed when using a Survival Guide the player was placed at a position near the Survival Guide but not directly next or ON the Guide.

This all began because of the below issue with the placement of the player at the Survival Guide in Romaeve. In my post-code fix of that placement, I audited all of the other Survival Guide placements (to make sure that they were all working) and the oddity and non-standardness of player placement. At some, players were placed near, at some, players were placed far away, at some, players were placed directly ON the survival guide. This all /triggered me so I decided to standardize the player placement at all Survival Guides.

Biggest change: Position of Survival Guide in Romaeve was a full 36 points different on the X-axis from where the Survival Guide book actually is (most likely an accidental inverse of numbers (51 instead of 15)).

I affirm:

  • that I agree to Project Topaz's Limited Contributor License Agreement, as written on this date
  • that I've tested my code since the last commit in the PR, and will test after any later commits

… Guide teleport is used, the player is placed ON or directly next to a Guide

Biggest change: Position of Survival Guide in Romaeve was a full 36 points different on the X-axis from where the Survival Guide book actually is (most likely an accidental inverse of numbers (51 instead of 15).
@EpicTaru EpicTaru marked this pull request as draft October 21, 2020 03:50
@EpicTaru
Copy link
Contributor Author

EpicTaru commented Oct 21, 2020

I've decided to convert this to draft and work on rotation of player when placed at the target guide.

Edit: DONE!!!

By default, I'll set it so they are placed in front of the guide, facing it. If navmesh issues prevent this, you'll be placed on the left or right side, facing the guide. If neither of these are able to be used, I'll place you on the guide, facing out from it (as if you were the open guide book, but you had eyes, looking out at people that are standing in front of the guide).....but don't think I'll need this last option at all.

Any thoughts/objections?

@EpicTaru EpicTaru changed the title --Audited POSes of all Survival Guides to ensure that when a Survival… Audited POSes of all Survival Guides Oct 21, 2020
…ed after selecting a zone to teleport to thru the Survival Guide teleport system.

The player will be placed facing the guide (as if they were reading it) or to the left of the guide (still facing the guide) if navmesh/environment limitations didn't permit the first option.

Second option was only used on less than a handful of zones.

Placement away from the guide was also standardized to be within a set distance range (around 1.1 to 1.3 yalms away) (range used instead of because of the bobbing of the guides)
@EpicTaru EpicTaru marked this pull request as ready for review October 26, 2020 22:07
@EpicTaru EpicTaru changed the title Audited POSes of all Survival Guides Audited POS destinations of players at all Survival Guides Oct 31, 2020
@EpicTaru EpicTaru changed the title Audited POS destinations of players at all Survival Guides Standardized POS destinations of players at all Survival Guides Nov 4, 2020
@zach2good zach2good merged commit f780862 into project-topaz:release Nov 4, 2020
@EpicTaru EpicTaru deleted the SurvivalGuidePOSAudit branch November 4, 2020 22:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants