Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fsync after pwal flush #37

Merged
merged 2 commits into from
Sep 28, 2023
Merged

fsync after pwal flush #37

merged 2 commits into from
Sep 28, 2023

Conversation

ban-nobuhiro
Copy link
Contributor

pwal ファイルの flush 後に fsync を追加する変更です。
それを実現するために、ofstream / ostream で実現されていたファイルの書込処理を
stdio の FILE* ベースのものに変更しました。

エラーチェックは

  • fsync に失敗した場合は abort します
  • 今までチェックしていた部分は同様にチェックします
  • 今までチェックしていなかった部分は、チェックを実装していません。今後追加の予定です。

@ban-nobuhiro
Copy link
Contributor Author

案件: https://github.com/project-tsurugi/tsurugi-issues/issues/363

@t-horikawa
Copy link
Contributor

LGTM

@ban-nobuhiro
Copy link
Contributor Author

マージします

@ban-nobuhiro ban-nobuhiro merged commit 6df9223 into master Sep 28, 2023
6 checks passed
@ban-nobuhiro ban-nobuhiro deleted the fsync-stdio branch October 3, 2023 08:36
@ban-nobuhiro ban-nobuhiro mentioned this pull request Oct 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t-horikawa t-horikawa Awaiting requested review from t-horikawa t-horikawa is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ban-nobuhiro @t-horikawa