Skip to content
Limestone-CI

Fix compaction start condition to ensure all relevant PWAL sessions a… #767

Sign in to view logs

Fix compaction start condition to ensure all relevant PWAL sessions a…

Fix compaction start condition to ensure all relevant PWAL sessions a… #767

GitHub Actions / Clang-Tidy failed Dec 12, 2024 in 0s

[Clang-Tidy] 3 warnings

[Clang-Tidy] 3 warnings

Annotations

Check warning on line 51 in include/limestone/api/datastore.h

See this annotation in the file changed.

@github-actions github-actions / Clang-Tidy

cppcoreguidelines-virtual-class-destructor 

destructor of 'datastore' is public and non-virtual

Check warning on line 34 in src/limestone/rotation_result.cpp

See this annotation in the file changed.

@github-actions github-actions / Clang-Tidy

performance-unnecessary-value-param 

the const qualified parameter 'filename' is copied for each invocation; consider making it a reference

Check warning on line 35 in src/limestone/rotation_result.h

See this annotation in the file changed.

@github-actions github-actions / Clang-Tidy

google-explicit-constructor,hicpp-explicit-conversions 

single-argument constructors must be marked explicit to avoid unintentional implicit conversions
View more details on GitHub Actions