Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MIGENG-33 - UX Implementation - Report Management UI - Fix percentage values sent to the backend #24

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

carlosthe19916
Copy link
Member

  • Before:
    The user writes 5%, then the UI sends to the backend the value of 5 as a number.

  • After
    The user writes 5%, then the UI sends to the backend the value of 0.05 as a number.

This change applies to:

  1. yearOverYearGrowthRatePercentage
  2. percentageOfHypervisorsMigratedOnYear1
  3. percentageOfHypervisorsMigratedOnYear2
  4. percentageOfHypervisorsMigratedOnYear3

Screenshot from 2019-07-09 16-29-39

@codecov-io
Copy link

codecov-io commented Jul 18, 2019

Codecov Report

Merging #24 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #24   +/-   ##
=======================================
  Coverage   73.13%   73.13%           
=======================================
  Files          35       35           
  Lines         830      830           
  Branches      159      159           
=======================================
  Hits          607      607           
  Misses        202      202           
  Partials       21       21
Impacted Files Coverage Δ
src/pages/ReportsUpload/ReportsUpload.tsx 43.18% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d814df9...8848f29. Read the comment docs.

@carlosthe19916 carlosthe19916 added the Ready for review The PR is ready to be reviewed label Jul 18, 2019
@carlosthe19916 carlosthe19916 removed the Ready for review The PR is ready to be reviewed label Apr 7, 2020
@mrizzi mrizzi added the On hold Code is ready but we have to wait before merging it label Apr 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
On hold Code is ready but we have to wait before merging it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants