-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci(deps): bump minio test dependency #2555
Conversation
97c0f90
to
229a312
Compare
Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2555 +/- ##
=======================================
Coverage 92.72% 92.72%
=======================================
Files 169 169
Lines 22467 22467
=======================================
Hits 20832 20832
Misses 1018 1018
Partials 617 617 ☔ View full report in Codecov by Sentry. |
@jkroepke just trying to understand what the scope of this PR is? Moving from stable releases to what looks like nightly releases sounds risky for us. |
This PR moved from an outdated minio tag to a latest stable release. The tag
The newer SDKs in distribution project are using S3 commands, which are not supported in 3 years old minio versions. |
@jkroepke I see. @peusebiu pls review this also. LGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
https://github.com/project-zot/zot/actions/runs/10074657923/job/27886068599 |
The minio dependency was already included in that PR #2532, but the warning didn't appear before. See: https://github.com/project-zot/zot/actions/runs/10029976719/job/27718800529?pr=2532 - new minio version, all fine. |
What type of PR is this?
cleanup
Which issue does this PR fix:
Cut off from #2532
What does this PR do / Why do we need it:
The new distribution version has some issues with old minio version. The ListObjectV2 returns Not Implemented
https://github.com/project-zot/zot/actions/runs/10026506554/job/27710895216?pr=2532#step:10:36
If an issue # is not available please add repro steps and logs showing the issue:
Testing done on this change:
Automation added to e2e:
Will this break upgrades or downgrades?
Does this PR introduce any user-facing change?:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.