Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(deps): bump minio test dependency #2555

Merged
merged 1 commit into from
Jul 24, 2024

Conversation

jkroepke
Copy link
Contributor

@jkroepke jkroepke commented Jul 21, 2024

What type of PR is this?

cleanup

Which issue does this PR fix:

Cut off from #2532

What does this PR do / Why do we need it:

The new distribution version has some issues with old minio version. The ListObjectV2 returns Not Implemented

https://github.com/project-zot/zot/actions/runs/10026506554/job/27710895216?pr=2532#step:10:36

If an issue # is not available please add repro steps and logs showing the issue:

Testing done on this change:

Automation added to e2e:

Will this break upgrades or downgrades?

Does this PR introduce any user-facing change?:


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jkroepke jkroepke force-pushed the upgrade-minio branch 2 times, most recently from 97c0f90 to 229a312 Compare July 21, 2024 07:38
Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>
Copy link

codecov bot commented Jul 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.72%. Comparing base (26be383) to head (f6ce3b4).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2555   +/-   ##
=======================================
  Coverage   92.72%   92.72%           
=======================================
  Files         169      169           
  Lines       22467    22467           
=======================================
  Hits        20832    20832           
  Misses       1018     1018           
  Partials      617      617           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rchincha
Copy link
Contributor

@jkroepke just trying to understand what the scope of this PR is? Moving from stable releases to what looks like nightly releases sounds risky for us.

@jkroepke
Copy link
Contributor Author

This PR moved from an outdated minio tag to a latest stable release.

The tag edge-cicd which is used in zot main is 3 years old. -> https://hub.docker.com/r/minio/minio/tags?page=&page_size=&ordering=&name=edge-cicd

RELEASE.2024-07-16T23-46-41Z is just a stable release. -> https://github.com/minio/minio/releases/tag/RELEASE.2024-07-16T23-46-41Z

The newer SDKs in distribution project are using S3 commands, which are not supported in 3 years old minio versions.

@rchincha
Copy link
Contributor

@jkroepke I see.

@peusebiu pls review this also.

LGTM

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andaaron andaaron merged commit 048e591 into project-zot:main Jul 24, 2024
39 checks passed
@jkroepke jkroepke deleted the upgrade-minio branch July 24, 2024 11:07
@rchincha
Copy link
Contributor

https://github.com/project-zot/zot/actions/runs/10074657923/job/27886068599
^ After the merge, the clustering test which uses minio is now slower??

@jkroepke
Copy link
Contributor Author

jkroepke commented Jul 25, 2024

project-zot/zot/actions/runs/10074657923/job/27886068599 ^ After the merge, the clustering test which uses minio is now slower??

The minio dependency was already included in that PR #2532, but the warning didn't appear before.

See: https://github.com/project-zot/zot/actions/runs/10029976719/job/27718800529?pr=2532 - new minio version, all fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants